On Sat, 20 Jan 2007 00:10:51 +0300
Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
> Juergen Beisert reported that the following option doesn't work for him
>
> video=gx1fb:[EMAIL PROTECTED]
>
> though sisfb was able to parse similar option correctly.
>
And does this patch fix it for him? ;)
> ---
>
> drivers/video/geode/gx1fb_core.c | 29 ++++++++++++++++++++++++++++-
> 1 file changed, 28 insertions(+), 1 deletion(-)
>
> --- a/drivers/video/geode/gx1fb_core.c
> +++ b/drivers/video/geode/gx1fb_core.c
> @@ -401,6 +401,30 @@ static void gx1fb_remove(struct pci_dev
> framebuffer_release(info);
> }
>
> +#ifndef MODULE
> +static void __init gx1fb_setup(char *options)
> +{
> + char *this_opt;
> +
> + if (!options || !*options)
> + return;
> +
> + while ((this_opt = strsep(&options, ","))) {
> + if (!*this_opt)
> + continue;
> +
> + if (!strncmp(this_opt, "mode:", 5))
> + strlcpy(mode_option, this_opt + 5, sizeof(mode_option));
> + else if (!strncmp(this_opt, "crt:", 4))
> + crt_option = !!simple_strtoul(this_opt + 4, NULL, 0);
> + else if (!strncmp(this_opt, "panel:", 6))
> + strlcpy(panel_option, this_opt + 6,
> sizeof(panel_option));
> + else
> + strlcpy(mode_option, this_opt, sizeof(mode_option));
> + }
> +}
> +#endif
> +
> static struct pci_device_id gx1fb_id_table[] = {
> { PCI_VENDOR_ID_CYRIX, PCI_DEVICE_ID_CYRIX_5530_VIDEO,
> PCI_ANY_ID, PCI_ANY_ID, PCI_BASE_CLASS_DISPLAY << 16,
> @@ -420,8 +444,11 @@ static struct pci_driver gx1fb_driver =
> static int __init gx1fb_init(void)
> {
> #ifndef MODULE
> - if (fb_get_options("gx1fb", NULL))
> + char *option = NULL;
> +
> + if (fb_get_options("gx1fb", &option))
> return -ENODEV;
> + gx1fb_setup(option);
> #endif
> return pci_register_driver(&gx1fb_driver);
> }
Possibly this should go through Jordan's git-geode tree. But that tree
seems to be kinda dead, so I'll file this under fbdev.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
