On Wed, Apr 27, 2016 at 02:01:15PM +0200, Vlastimil Babka wrote: > Check without side-effects should be easier to maintain. It also removes the > duplicated cpupid and flags reset done in !DEBUG_VM variant of both > free_pcp_prepare() and then bulkfree_pcp_prepare(). Finally, it enables > the next patch. >
Hmm, now the cpuid and flags reset is done in multiple places. While this is potentially faster, it goes against the comment "I don't like the duplicated code in free_pcp_prepare() from maintenance perspective". -- Mel Gorman SUSE Labs
