On (03/23/16 11:04), Petr Mladek wrote:
[..]
>                                         if (!need_flush_console)
>                                            schedule()
> 
>                                            # did one unnecessary
>                                            # cycle to get asleep

OK. well, didn't consider it to be a problem, but I'll make it
symmetric:
        we set need_flush_console under logbuf lock,
        we clear it under logbuf lock.

should be simpler.

> PS: If you touch the code, please rename printing_func() to
> printk_kthread_func() to make it more clear what it does.

oh, yes, was going to do it but somehow forgot.

        -ss

Reply via email to