On Wed, 10 Jan 2007, Jean Delvare wrote:
>
> This fixes the problem I reported. Thanks Roman!
>
> Linus, Andrew, if Roman's patch looks OK to you, can it please be
> applied before 2.6.20 is released?
I applied it, but looking closer at it, it becomes clear that Roman didn't
understand the problem with that patch.
This part:
const char __init linux_banner[] =
CANNOT work, because the stupid SuSE tool that look into the kernel binary
searches for "Linux version " as the thing, and as such the "linux_banner"
has to be the _first_ thing to trigger it for it to work.
Which is why "__init" is wrong. It causes the linker to either put it at
the end of the thing (which would break the SuSE tool). Alternatively it
causes section mismatch problems ("init" and "const" don't work that well
together), in which case it might work, but only due to toolchain bugs.
Grr.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
