On 13.3.2016 20:10, Moritz Fischer wrote: > This commit takes care of the coding style warnings > that are mostly due to a different comment style and > lines over 80 chars, as well as a dangling else. > > Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> > --- > drivers/net/ethernet/cadence/macb.c | 101 > +++++++++++++++--------------------- > 1 file changed, 43 insertions(+), 58 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/macb.c > b/drivers/net/ethernet/cadence/macb.c > index 4370f37..c2d31c5 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -58,8 +58,7 @@ > > #define GEM_MTU_MIN_SIZE 68 > > -/* > - * Graceful stop timeouts in us. We should allow up to > +/* Graceful stop timeouts in us. We should allow up to > * 1 frame time (10 Mbits/s, full-duplex, ignoring collisions) > */ > #define MACB_HALT_TIMEOUT 1230 > @@ -127,8 +126,7 @@ static void hw_writel(struct macb *bp, int offset, u32 > value) > writel_relaxed(value, bp->regs + offset); > } > > -/* > - * Find the CPU endianness by using the loopback bit of NCR register. When > the > +/* Find the CPU endianness by using the loopback bit of NCR register. When > the
TBH: I would rather see this converting to kernel-doc format instead of using this networking block. Also splitting this to more patches will be better. Just by categories but that's just my opinion. Thanks, Michal
