On Wed, Mar 09, 2016 at 10:46:55PM +0900, Namhyung Kim wrote:
> Hello,
>
> These are filter-related fixes and cleanups in the new hierarchy mode.
> Currently perf misbehaves in hierarchy mode when filter is applied.
> For example, it sometimes misses some (upper level) entries in the
> output or shows incorrect (very large) overhead.
>
> * Changes in v2)
> - update hist_entry__filter() to check multiple filters properly
> - add missing runtime filter check when adding hierarchy entries
> - recalculate total period using top-level entries (Jiri)
> - add more comment
>
>
> Before:
>
> $ perf report --hierarchy -s 'cpu,{dso,comm}' --comms swapper --stdio
> ...
> # Overhead CPU / Shared Object+Command
> # ........... ...........................
> #
> 13.79% [kernel.vmlinux] swapper
> 31.71% 000
> 13.80% [kernel.vmlinux] swapper
> 0.43% [e1000e] swapper
> 11.89% [kernel.vmlinux] swapper
> 9.18% [kernel.vmlinux] swapper
>
> After:
>
> # Overhead CPU / Shared Object+Command
> # ........... ...............................
> #
> 33.09% 003
> 13.79% [kernel.vmlinux] swapper
> 31.71% 000
> 13.80% [kernel.vmlinux] swapper
> 0.43% [e1000e] swapper
> 21.90% 002
> 11.89% [kernel.vmlinux] swapper
> 13.30% 001
> 9.18% [kernel.vmlinux] swapper
>
>
> It's also available on 'perf/hierarchy-filter-v2' branch in my tree
>
> git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
>
> any feedback are welcome.
looks good to me, the 'F' toggle shows sane number for me now
Acked-and-tested-by: Jiri Olsa <jo...@kernel.org>
thanks,
jirka
