On Fri, 5 Feb 2016, Benjamin Tissoires wrote: > > This adds a warning message stating that the sysfs group was not > > able to be created for the passed hid_device structure pointer > > with dev_warn. > > > > Signed-off-by: Nicholas Krause <xerofo...@gmail.com> > > --- > > drivers/hid/hid-multitouch.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > > index 296d499..b2b2451 100644 > > --- a/drivers/hid/hid-multitouch.c > > +++ b/drivers/hid/hid-multitouch.c > > @@ -1133,6 +1133,8 @@ static int mt_probe(struct hid_device *hdev, const > > struct hid_device_id *id) > > return ret; > > > > ret = sysfs_create_group(&hdev->dev.kobj, &mt_attribute_group); > > + if (ret) > > + dev_warn(&hdev->dev, "Cannot allocate sysfs group for %s\n", > > hdev->name); > > Just nitpicking here. Checkpatch.pl complains about a line over 80 > characters here. Could you (or maybe just Jiri) fix that? > > Otherwise: > Reviewed-by: Benjamin Tissoires <benajmin.tissoi...@redhat.com>
Thanks. I've reformatted the source (and also changelog a bit) and applied. -- Jiri Kosina SUSE Labs
