On Wed, Jan 20, 2016 at 10:15:20AM +0900, Namhyung Kim wrote: > The --exclude-other option sets HIST_FILTER__PARENT bit and it's only > set when a hist entry was created. DSO filters don't change this so > no need to have the check in hists__filter_by_dso() IMHO. > > Signed-off-by: Namhyung Kim <[email protected]>
Acked-by: Jiri Olsa <[email protected]> jirka > --- > tools/perf/util/hist.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c > index 9354455aec5b..7c9af05726ad 100644 > --- a/tools/perf/util/hist.c > +++ b/tools/perf/util/hist.c > @@ -1483,9 +1483,6 @@ void hists__filter_by_dso(struct hists *hists) > for (nd = rb_first(&hists->entries); nd; nd = rb_next(nd)) { > struct hist_entry *h = rb_entry(nd, struct hist_entry, rb_node); > > - if (symbol_conf.exclude_other && !h->parent) > - continue; > - > if (hists__filter_entry_by_dso(hists, h)) > continue; > > -- > 2.7.0 >
