On Wed, Dec 23, 2015 at 11:59:25AM +0100, Marek Szyprowski wrote: > This patch ensures that existing bus match callbacks don't return > negative values (which might be interpreted as potential errors in the > future) in case of positive match.
This actually can't return a negative number - only valid devid bits are 0 to 9 inclusive, and this isn't going to ever change. So the patch isn't strictly necessary, but is good from the point of view of ensuring consistency. Hence: > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> Acked-by: Russell King <rmk+ker...@arm.linux.org.uk> > --- > arch/arm/common/sa1111.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c > index 3d22494..fb0a0a4 100644 > --- a/arch/arm/common/sa1111.c > +++ b/arch/arm/common/sa1111.c > @@ -1290,7 +1290,7 @@ static int sa1111_match(struct device *_dev, struct > device_driver *_drv) > struct sa1111_dev *dev = SA1111_DEV(_dev); > struct sa1111_driver *drv = SA1111_DRV(_drv); > > - return dev->devid & drv->devid; > + return !!(dev->devid & drv->devid); > } > > static int sa1111_bus_suspend(struct device *dev, pm_message_t state) > -- > 1.9.2 > -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
