This doesn't just eliminate needless redundancy (plus avoid a possible disconnect if one string instance gets changed without the other(s)), but also eliminates a warning some gcc versions emit ("array access beyond array bounds", observed with 4.3.4) in the 32-bit case.
Signed-off-by: Jan Beulich <jbeul...@suse.com> --- arch/x86/kernel/cpu/microcode/core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- 4.4-rc6/arch/x86/kernel/cpu/microcode/core.c +++ 4.4-rc6-x86-ucode-early-string/arch/x86/kernel/cpu/microcode/core.c @@ -83,13 +83,11 @@ static bool __init check_loader_disabled { #ifdef CONFIG_X86_32 const char *cmdline = (const char *)__pa_nodebug(boot_command_line); - const char *opt = "dis_ucode_ldr"; - const char *option = (const char *)__pa_nodebug(opt); + const char *option = (const char *)__pa_nodebug(__setup_str_disable_loader); bool *res = (bool *)__pa_nodebug(&dis_ucode_ldr); - #else /* CONFIG_X86_64 */ const char *cmdline = boot_command_line; - const char *option = "dis_ucode_ldr"; + const char *option = __setup_str_disable_loader; bool *res = &dis_ucode_ldr; #endif -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/