>-----Original Message----- >From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- >ow...@vger.kernel.org] On Behalf Of Andy Shevchenko >Sent: Wednesday, November 25, 2015 10:33 PM >To: Thomas Gleixner <t...@linutronix.de> >Cc: linux-kernel@vger.kernel.org; linux-...@vger.kernel.org; linux- >p...@vger.kernel.org; Ingo Molnar <mi...@redhat.com>; Peter Anvin ><h...@zytor.com>; Wolfram Sang <w...@the-dreams.de>; Zhang, Rui ><rui.zh...@intel.com>; Eduardo Valentin <edubez...@gmail.com>; Kweh, Hock >Leong <hock.leong.k...@intel.com> >Subject: Re: [PATCH v2 1/1] x86/platform/iosf_mbi: Remove duplicate definitions > >On Wed, 2015-11-25 at 15:20 +0100, Thomas Gleixner wrote: >> On Wed, 11 Nov 2015, Andy Shevchenko wrote: >> >> > The read and write opcodes are global for all units on SoC and even >> across >> > Intel SoCs. Remove duplication of corresponding constants. At the >> same time >> > convert all current users. >> > >> > No functional change. >> > >> > Cc: Thomas Gleixner <t...@linutronix.de> >> > Cc: Ingo Molnar <mi...@redhat.com> >> > Cc: Peter Anvin <h...@zytor.com> >> > Cc: Wolfram Sang <w...@the-dreams.de> >> > Cc: Zhang Rui <rui.zh...@intel.com> >> > Cc: Eduardo Valentin <edubez...@gmail.com> >> > Cc: Hock Leong Kweh <hock.leong.k...@intel.com> > >Eduardo, Rui, can you provide your ACKs or comments about the patch? > Rui, I have reviewed the change on drivers/thermal/intel_quark_dts_thermal.c. Yes, I gave my ACK here.