Hi Arnaldo, On Thu, Nov 19, 2015 at 10:41:32AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Nov 09, 2015 at 02:45:39PM +0900, Namhyung Kim escreveu: > > This is a preparation to support for printing other type of callchain > > value like count or period. > > > > Acked-by: Brendan Gregg <[email protected]> > > Signed-off-by: Namhyung Kim <[email protected]> > > ---
[SNIP] > > +char *callchain_node__sprintf_value(struct callchain_node *node, > > + char *bf, size_t bfsize, u64 total) > > sprintf doesn't require a bfsize, snprintf does, but we don't use that, > so renaming it to callchain_node__scnprintf_value() so that we recall > the semantic associated with this operation. OK, and thank you for doing this! Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
