On Thu, Nov 05, 2015 at 09:10:47AM +0100, SF Markus Elfring wrote: > diff --git a/drivers/staging/rdma/hfi1/file_ops.c > b/drivers/staging/rdma/hfi1/file_ops.c > index aae9826..204d1d0 100644 > --- a/drivers/staging/rdma/hfi1/file_ops.c > +++ b/drivers/staging/rdma/hfi1/file_ops.c > @@ -313,7 +313,7 @@ static ssize_t hfi1_file_write(struct file *fp, const > char __user *data, > case HFI1_CMD_SDMA_STATUS_UPD: > break; > case HFI1_CMD_CREDIT_UPD: > - if (uctxt && uctxt->sc) > + if (uctxt) > sc_return_credits(uctxt->sc);
Relying on hidden sanity checks makes the code harder to read. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
