On Wed, Nov 04, 2015 at 03:51:01PM +0100, Dmitry Vyukov wrote: > To clarify, yes, documentation and tooling was my main motivation.
Right; I don't object to having _ctrl() methods purely for documentation purposes, I keep finding places we rely on them. Having them stand out better might be useful. > It is usually helpful to see acquire/release, rmb/wmb pairs, and so it > is useful to know that something below is ordered wrt this load by > means of a control dependency (which effectively becomes an acquire, > and there must be a pairing release somewhere). You need at least a trailing smp_rmb() before you cover the ACQUIRE semantics -- or have no trailing reads at all of course. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/