On Tue, Apr 29, 2025 at 5:08 PM Thomas Richard
<[email protected]> wrote:
>
> Using devm_pinctrl_register_mappings(), the core can automatically
> unregister pinctrl mappings.
...
> +static void devm_pinctrl_unregister_mappings(void *data)
data --> maps
> +{
> + pinctrl_unregister_mappings(*(const struct pinctrl_map **)data);
Why can't you use the 'maps' pointer directly here?
> +}
> +
> +/**
> + * devm_pinctrl_register_mappings() - Resource managed
> pinctrl_register_mappings()
> + * @dev: device for which mappings are registered
> + * @maps: the pincontrol mappings table to register. Note the pinctrl-core
> + * keeps a reference to the passed in maps, so they should _not_ be
> + * marked with __initdata.
> + * @num_maps: the number of maps in the mapping table
Missing Return: section. Please, validate the kernel doc.
> + */
...
> void pinctrl_provide_dummies(void);
> +
> #else
Stray change.
--
With Best Regards,
Andy Shevchenko
