On Thu, Oct 24, 2024 at 03:14:31PM -0600, Gustavo A. R. Silva wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > Address the following warnings by changing the type of the middle struct > members in a couple of composite structs, which are currently causing > trouble, from `struct sockaddr` to `struct __kernel_sockaddr_legacy` in > UAPI, and `struct sockaddr_legacy` for the rest of the kernel code. > > include/uapi/linux/route.h:33:25: warning: structure containing a flexible > array member is not at the end of another structure > [-Wflex-array-member-not-at-end] > include/uapi/linux/route.h:34:25: warning: structure containing a flexible > array member is not at the end of another structure > [-Wflex-array-member-not-at-end] > include/uapi/linux/route.h:35:25: warning: structure containing a flexible > array member is not at the end of another structure > [-Wflex-array-member-not-at-end > include/net/compat.h:34:25: warning: structure containing a flexible array > member is not at the end of another structure [-Wflex-array-member-not-at-end] > include/net/compat.h:35:25: warning: structure containing a flexible array > member is not at the end of another structure [-Wflex-array-member-not-at-end] > > Also, update some related code, accordingly. > > Signed-off-by: Gustavo A. R. Silva <gustavo...@kernel.org>
Looks right, including the helper prototype update. Reviewed-by: Kees Cook <k...@kernel.org> -- Kees Cook
