On Thu, Oct 24, 2024 at 03:13:45PM -0600, Gustavo A. R. Silva wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > Address the following warnings by changing the type of the middle struct > members in a couple of composite structs, which are currently causing > trouble, from `struct sockaddr` to `struct __kernel_sockaddr_legacy`. > > include/uapi/linux/if_arp.h:118:25: warning: structure containing a flexible > array member is not at the end of another structure > [-Wflex-array-member-not-at-end] > include/uapi/linux/if_arp.h:119:25: warning: structure containing a flexible > array member is not at the end of another structure > [-Wflex-array-member-not-at-end] > include/uapi/linux/if_arp.h:121:25: warning: structure containing a flexible > array member is not at the end of another structure > [-Wflex-array-member-not-at-end] > include/uapi/linux/if_arp.h:126:25: warning: structure containing a flexible > array member is not at the end of another structure > [-Wflex-array-member-not-at-end] > include/uapi/linux/if_arp.h:127:25: warning: structure containing a flexible > array member is not at the end of another structure > [-Wflex-array-member-not-at-end] > > Also, refactor some related code, accordingly. > > Signed-off-by: Gustavo A. R. Silva <gustavo...@kernel.org>
Reviewed-by: Kees Cook <k...@kernel.org> -- Kees Cook
