On 5 August 2013 22:11, Mark Brown <broo...@kernel.org> wrote:
> On Mon, Aug 05, 2013 at 07:37:10PM +0800, Andy Green wrote:
>> On 5 August 2013 18:59, Mark Brown <broo...@kernel.org> wrote:
>
>> >  - The regmap change isn't something that I've seen upstream...
>
>> If you mean where did the original come from
>
> I mean I haven't seen that warning that I'm aware of.
>
>> commit 5a08d15602987bbdff3407d7645f95b7a70f1a6f
>> Author: Stephen Warren <swar...@nvidia.com>
>> Date:   Wed Mar 20 17:02:02 2013 -0600
>
>>     regmap: don't corrupt work buffer in _regmap_raw_write()
>
> Note that the above change is part of v3.10...

I know, it's just unclear what you were saying about "the regmap
change isn't something that I've seen upstream..."

I went through and split out the fixes after examining each one.

1) warning elimination: arm: silence THUMB2 no unwind warning

I think RMK wants it to blow warnings, the issue is there's no frame
context if you build THUMB2 (which we are).  In Kconfig

# RMK wants arm kernels compiled with frame pointers or stack unwinding.
# If you know what you are doing and are willing to live without stack
# traces, you can get a slightly smaller kernel by setting this option to
# n, but then RMK will have to kill you ;).
config FRAME_POINTER
        bool
        depends on !THUMB2_KERNEL

so I doubt he'll accept a patch silencing it.  For me, it's a
pointless warning and for lsk fixed at 3.10 it's also pointless IMO.

2) warning-elimination: android: binder

This seems to be a problem with a patch already upstream

3) warning-elimination: androidization: mm

Problem coming from Androidization patches

4) warning-elimination: ata: ata_hpa_resize default assignment

Issue is upstream but I can't reproduce original compiler warning

5) warning-elimination: ion: use size_t-specific format

Introduced in Androidization

6) warning-elimination: nobody uses cci_pmu_destroy

Presumably coming from the CCI stuff Tixy pulled in

7) warning-elimination: regmap: cast pointer arg from int

This seems to be a genuine issue of passing an int to a function
wanting a const void *.  However I can't reproduce the warning.

8) warning-elimination: usb: dwc3

This only made problems if you have CONFIG_PM but not CONFIG_SUSPEND,
dunno if people care or not.


So 3 and 5 are out-of-mainline Androidizaton issues.

6 only exists on ARM LT tree -> llct / lsk and need to be dealt with here.

1 4, and 8 I doubt anyone will buy upstream, but you should still
consider 1.  4 can't be demonstrated to be a problem right now
(although it has been...)  8 we turned on SUSPEND ourselves since it
was a problem.

2 is a problem from mainline.

7 is your department.

-Andy

Attachment: warning elimination: arm: silence THUMB2 no unwind warning
Description: Binary data

Attachment: warning-elimination: ion: use size_t-specific format
Description: Binary data

Attachment: warning-elimination: nobody uses cci_pmu_destroy
Description: Binary data

Attachment: warning-elimination: regmap: cast pointer arg from int
Description: Binary data

Attachment: warning-elimination: androidization: mm
Description: Binary data

Attachment: warning-elimination: ata: ata_hpa_resize default assignment
Description: Binary data

Attachment: warning-elimination: usb: dwc3
Description: Binary data

Attachment: warning-elimination: android: binder
Description: Binary data

_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev

Reply via email to