On Mon, Jan 31, 2011 at 10:00 AM, Rob Herring <robherri...@gmail.com> wrote: > Thomas, > > On 01/31/2011 10:28 AM, thomas.abra...@linaro.org wrote: >> >> From: Thomas Abraham<thomas.abra...@linaro.com> >> >> Add support for retrieving memory and irq resource information >> from device tree for Samsung's SDHCI controller driver. >> >> Signed-off-by: Thomas Abraham<thomas.abra...@linaro.org> >> --- >> >> The modification will be made more generic to support both >> DT and non-DT versions of the driver without the #ifdef's. >> For now, this patch is for review and to understand if the >> approach adopted to obtain resource information from the >> device tree is appropriate. >>
> You are missing an of_match_table. This patch could not work without it. Actually, the way he is implementing it the of_match_table would have absolutely no effect. However, you are right, it *should* be implemented so that it binds via the of_match_table. I suspect Thomas did it this way because he doesn't yet have an easy way to get his platform devices registered from the device tree. g. _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
