On Fri, Aug 21, 2015 at 5:18 PM, tisimst <tisimst.lilyp...@gmail.com> wrote:
>
>
> On 8/21/2015 4:14 PM, David Nalesnik-2 [via Lilypond] wrote:
>
> Hi,
>
> On Fri, Aug 21, 2015 at 2:37 PM, David Kastrup <[hidden email]
> <http:///user/SendEmail.jtp?type=node&node=179907&i=0>> wrote:
>
>> tisimst <[hidden email]
>> <http:///user/SendEmail.jtp?type=node&node=179907&i=1>> writes:
>>
>> > On 8/21/2015 5:40 AM, Andrew Bernard [via Lilypond] wrote:
>> There was one oddity I encountered in the process, though. When I
>> > irregularized the flags, I noticed that a flag is printed for EVERY note
>> > within the same chord! Crazy, I know. Sounds like an unnecessary thing
>> > if you ask me.
>>
>> Sounds like an undiscovered bug if you ask me.
>>
>
> Yes, I think so.
>
> It appears that there is no provision for redundant flags in Flag::print.
>
> The attached is a diff for a quick test fix. Only one of the flags is
> actually pointed to by Stem.flag, and we keep it, suiciding the others.
> Don't know if that's adequate.
>
> *Duh* why create them in the first place? See attached patch.
>
> You can compare the results with and without using this:
>
>
> Now that's good customer service :-) I'd like to see ANY tech company fix
> a customer-reported bug that fast. Thanks David!
>
Well, it will be some time before it gets into the program :)
David
From 3dcd8d730863aa575b0774c3abba3f36301417c3 Mon Sep 17 00:00:00 2001
From: David Nalesnik <david.nales...@gmail.com>
Date: Fri, 21 Aug 2015 18:50:34 -0500
Subject: [PATCH] Don't create extra flags in chords
---
lily/stem-engraver.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lily/stem-engraver.cc b/lily/stem-engraver.cc
index a84dd70..2f2eaf8 100644
--- a/lily/stem-engraver.cc
+++ b/lily/stem-engraver.cc
@@ -158,7 +158,8 @@ Stem_engraver::acknowledge_rhythmic_head (Grob_info gi)
Stem::add_head (stem_, gi.grob ());
if (Stem::is_normal_stem (stem_)
- && Stem::duration_log (stem_) > 2)
+ && Stem::duration_log (stem_) > 2
+ && !(unsmob<Grob> (stem_->get_object ("flag"))))
{
Item *flag = make_item ("Flag", stem_->self_scm ());
flag->set_parent (stem_, X_AXIS);
--
1.9.1
_______________________________________________
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user
