On 2020/05/10 10:02:27, hanwenn wrote: > On 2020/05/10 10:00:54, hahnjo wrote: > > On 2020/05/10 09:29:48, hanwenn wrote: > https://codereview.appspot.com/566080043/diff/560020046/lily/freetype.cc#newcode149 > > > lily/freetype.cc:149: return ((Path_interpreter *) user)->moveto (*to); > > > On 2020/05/10 09:16:59, hahnjo wrote: > > > > Do you want to create copies of the arguments? (here and for the other > > > > functions) > > > > > > yes. I find it easier to reason about and read. It's all inlined anyway. > > > > const refs should work the same AFAICS > > Yes, I know. Do you want me to change this?
Yes, const refs avoid relying on compiler optimizations to remove the copies. https://codereview.appspot.com/566080043/
