https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc File lily/freetype.cc (right):
https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode105 lily/freetype.cc:105: bool is_tt = (0 == strcmp ("TrueType", FT_Get_Font_Format (face))); Can we have this as a comparison of std::string to avoid strcmp? https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode126 lily/freetype.cc:126: else if (outline->tags[j] & 1) is there a define for this magic number? https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode135 lily/freetype.cc:135: else if (outline->tags[j] & 2) same https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode162 lily/freetype.cc:162: } This code looks very familiar. Don't we already have it in make_draw_bezier_boxes? https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode164 lily/freetype.cc:164: else I'd advocate another else if and have an assert in the else branch (but I know it's been this way in the old code) https://codereview.appspot.com/569700043/diff/582060043/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/569700043/diff/582060043/lily/stencil-integral.cc#newcode237 lily/stencil-integral.cc:237: points[i + 1]); AFAICS this is switching from CCW to CW - is there an advantage for this? https://codereview.appspot.com/569700043/
