https://codereview.appspot.com/547980044/diff/567490043/lily/include/skyline.hh File lily/include/skyline.hh (right):
https://codereview.appspot.com/547980044/diff/567490043/lily/include/skyline.hh#newcode152 lily/include/skyline.hh:152: } Why do you need all of this in the header file? As far as I can see, nobody else is calling these methods, so the argument of inlinining does not apply. https://codereview.appspot.com/547980044/diff/567490043/lily/skyline-pair.cc File lily/skyline-pair.cc (left): https://codereview.appspot.com/547980044/diff/567490043/lily/skyline-pair.cc#oldcode100 lily/skyline-pair.cc:100: Skyline_pair::print_points () const You should not delete a function without removing the declaration in lily/include/skyline-pair.hh. Also this seems unrelated to the performance improvements. https://codereview.appspot.com/547980044/diff/567490043/lily/skyline.cc File lily/skyline.cc (right): https://codereview.appspot.com/547980044/diff/567490043/lily/skyline.cc#newcode780 lily/skyline.cc:780: Skyline::to_segments (Axis horizon_axis) const What's the advantage of this code over the old method? https://codereview.appspot.com/547980044/diff/567490043/scm/define-grobs.scm File scm/define-grobs.scm (right): https://codereview.appspot.com/547980044/diff/567490043/scm/define-grobs.scm#newcode1657 scm/define-grobs.scm:1657: (stencil . ,ly:paper-column::print) Is this change intentional? And intentionally in this review? https://codereview.appspot.com/547980044/
