https://codereview.appspot.com/547980044/diff/548010043/lily/skyline.cc
File lily/skyline.cc (right):

https://codereview.appspot.com/547980044/diff/548010043/lily/skyline.cc#newcode348
lily/skyline.cc:348: result.push_back (buildings->at (0));
at() involves a boundary check that is not necessary here.  front() or
[0] would be better.

https://codereview.appspot.com/547980044/diff/548010043/lily/skyline.cc#newcode862
lily/skyline.cc:862: // testing
I love the idea of testing, though I think we'll want to find a way to
avoid bloating LilyPond with test code.

https://codereview.appspot.com/547980044/

Reply via email to