----- Original Message ----- From: <david.nales...@gmail.com> To: <philehol...@googlemail.com>; <lemzw...@googlemail.com>; <lilyli...@googlemail.com>; <em...@philholmes.net>; <m...@philholmes.net>
Cc: <lilypond-devel@gnu.org>; <re...@codereview-hr.appspotmail.com>
Sent: Tuesday, May 27, 2014 3:12 PM
Subject: Re: Reposition voiced rests (Issue 3902) (issue 101720045)



https://codereview.appspot.com/101720045/diff/1/lily/rest.cc
File lily/rest.cc (right):

https://codereview.appspot.com/101720045/diff/1/lily/rest.cc#newcode138
lily/rest.cc:138:
To be consistent with your change above, shouldn't this be:

  return neutral + 2 * dir;

https://codereview.appspot.com/101720045/


Probably. I can't think of a use case where this code would actually be exercised, so would welcome a suggestion.

--
Phil Holmes

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to