The changes to side-position-interface.cc are more extensive than I am willing to figure out. Good luck.
https://codereview.appspot.com/6827072/diff/38003/lily/box-quarantine.cc File lily/box-quarantine.cc (right): https://codereview.appspot.com/6827072/diff/38003/lily/box-quarantine.cc#newcode81 lily/box-quarantine.cc:81: Real epsilon = 1.0e-10; A bit small. If anyone ever does anything strange, like overriding one fingering to a point stencil and also setting FingeringColumn 'padding = 0, then the shift in each iteration is actually epsilon. I figure it would take about 3 million seconds to set a 3-finger chord, so the boxes would be in quarantine for just about forty days.
> I simplified the loop <http://codereview.appspot.com/6854121/>
I'm OK w/ the simplification, but I'd like it in box-quarantine if
possible. I cannot figure out how to put it in box-quarantine. https://codereview.appspot.com/6827072/diff/38003/lily/fingering-column.cc File lily/fingering-column.cc (right): https://codereview.appspot.com/6827072/diff/38003/lily/fingering-column.cc#newcode72 lily/fingering-column.cc:72: origs.push_back(Interval (y_ext)); The array origs[] is not quite the same as the actual fingering positions, after the translate_axis() above. The difference is only important if the fingerings were different heights, but that could happen { \set fingeringOrientations = #'(left) <g-3 a-\tweak #'text "---" -0 b-3> } https://codereview.appspot.com/6827072/diff/38003/lily/skyline.cc File lily/skyline.cc (right): https://codereview.appspot.com/6827072/diff/38003/lily/skyline.cc#newcode236 lily/skyline.cc:236: Skyline::flatten_to_height (Real h) On 2012/11/29 08:28:31, mike7 wrote:
>
http://codereview.appspot.com/6827072/diff/18003/lily/skyline.cc#newcode234
> lily/skyline.cc:234: // Flatten to height h > What is the difference between this and
Skyline:::set_minimum_height()
> at line 817 ? >
Set minimum height allows for things over the minimum height to retain
their
skyline-ness, whereas this creates a flat skyline at height X.
The only places you use it, you could use set_minimum_height(), or just insert() a box of the height you need, since the skylines in question are empty. Looking up unfamiliar functions takes time for code maintainers. https://codereview.appspot.com/6827072/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
