Thank you for reviewing this, Neil!
On 2012/05/31 16:22:53, Neil Puttock wrote:
http://codereview.appspot.com/6255056/diff/5001/input/regression/shape-slurs.ly
File input/regression/shape-slurs.ly (right):
http://codereview.appspot.com/6255056/diff/5001/input/regression/shape-slurs.ly#newcode5
input/regression/shape-slurs.ly:5: @code{\\shape}. The blue slurs are
modified
from the default slurs shown first."
two spaces after full-stop/period
Done.
http://codereview.appspot.com/6255056/diff/5001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
http://codereview.appspot.com/6255056/diff/5001/ly/music-functions-init.ly#newcode1041
ly/music-functions-init.ly:1041: (_i "Offset control-points of
@var{grob} by
@var{offsets}. The argument
two spaces follow full stop/period
Done. (This is actually what I do instinctively. Here I was fighting
the impulse--with inconsistent results!)
http://codereview.appspot.com/6255056/diff/5001/ly/music-functions-init.ly#newcode1042
ly/music-functions-init.ly:1042: is a Scheme alist or list of alists.
Each
element of an alist represents
`offsets' isn't an alist: there's no (key . value) relationship in the
list of
number pairs
Done. This certainly makes more sense.
http://codereview.appspot.com/6255056/diff/5001/ly/music-functions-init.ly#newcode1046
ly/music-functions-init.ly:1046: (siblings (if (and (ly:grob? orig)
ly:grob-original always returns a grob, so this is unnecessary
Done.
http://codereview.appspot.com/6255056/diff/5001/ly/music-functions-init.ly#newcode1048
ly/music-functions-init.ly:1048: (ly:spanner-broken-into orig) '() ))
remove spurious whitespace
Done.
http://codereview.appspot.com/6255056/diff/5001/ly/music-functions-init.ly#newcode1051
ly/music-functions-init.ly:1051: (reverse (ly:grob-basic-properties
grob))))
fix indent (aligns with 'control-points)
Done.
http://codereview.appspot.com/6255056/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
