On 2012/05/28 20:23:37, janek wrote:
generally LGTM.

What about coloring the \shaped curves?  This would make checking
regtests more
obvious to an ordinary person who may be not familiar with this stuff.

Good idea!  I did this for both regression tests.


http://codereview.appspot.com/6255056/diff/1/input/regression/shape-other-curves.ly
File input/regression/shape-other-curves.ly (right):


http://codereview.appspot.com/6255056/diff/1/input/regression/shape-other-curves.ly#newcode19
input/regression/shape-other-curves.ly:19: \bar "||"
Instead of adding double barlines, i would separate different types of
curves by
placing them in separate systems.

Done.



http://codereview.appspot.com/6255056/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to