It would appear that you ignored <http://permalink.gmane.org/gmane.comp.gnu.lilypond.auto/465>, <http://permalink.gmane.org/gmane.comp.gnu.lilypond.auto/466>, the end of <http://permalink.gmane.org/gmane.comp.gnu.lilypond.devel/46312> and <http://permalink.gmane.org/gmane.comp.gnu.lilypond.auto/442>.
Code reviews take time, effort, and diligence. Patch testing can be done by yourself easily. If it isn't, it again takes time, effort, and diligence. It is a matter of courtesy not to waste those lightly, and treat the resources of your coworkers with the respect you want to have them treat yours. http://codereview.appspot.com/6109046/diff/9001/lily/ledger-line-spanner.cc File lily/ledger-line-spanner.cc (left): http://codereview.appspot.com/6109046/diff/9001/lily/ledger-line-spanner.cc#oldcode68 lily/ledger-line-spanner.cc:68: while (flip (&d) != DOWN); This was a _one_-iteration loop. After the change, it is a _two_-iterations loop. http://codereview.appspot.com/6109046/diff/9001/lily/slur.cc File lily/slur.cc (right): http://codereview.appspot.com/6109046/diff/9001/lily/slur.cc#newcode105 lily/slur.cc:105: ret.add_point (d[dir]); The loop does not appear to use the index downup. Anybody have an idea what's up with that? This is a faithful reproduction of the original loop, but does not appear to make sense. http://codereview.appspot.com/6109046/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
