http://codereview.appspot.com/5464045/diff/10002/ly/music-functions-init.ly File ly/music-functions-init.ly (right):
http://codereview.appspot.com/5464045/diff/10002/ly/music-functions-init.ly#newcode31 ly/music-functions-init.ly:31: %% need (scm markup-facility-defs)for markup? Wasn't this supposed to get removed? This was not supposed to be needed in user-level docs, right? http://codereview.appspot.com/5464045/diff/10002/ly/titling-init.ly File ly/titling-init.ly (right): http://codereview.appspot.com/5464045/diff/10002/ly/titling-init.ly#newcode1 ly/titling-init.ly:1: \version "2.15.20" Isn't the version string wrong here? http://codereview.appspot.com/5464045/diff/10002/scm/define-event-classes.scm File scm/define-event-classes.scm (right): http://codereview.appspot.com/5464045/diff/10002/scm/define-event-classes.scm#newcode20 scm/define-event-classes.scm:20: (ice-9 optargs) Why is optargs needed here? There is a define* below, but that looks like it should rather be plain define. http://codereview.appspot.com/5464045/diff/10002/scm/framework-ps.scm File scm/framework-ps.scm (right): http://codereview.appspot.com/5464045/diff/10002/scm/framework-ps.scm#newcode20 scm/framework-ps.scm:20: #:duplicates (replace)) What is with the duplicate? Should this be fixed? http://codereview.appspot.com/5464045/diff/10002/scm/framework-ps.scm#newcode429 scm/framework-ps.scm:429: (fancy-format port "/~a (~a)\n" field (metadata-encode (markup->string val)))))) Why would we need fancy-format here? The format codes are usual? http://codereview.appspot.com/5464045/diff/10002/scm/lily.scm File scm/lily.scm (right): http://codereview.appspot.com/5464045/diff/10002/scm/lily.scm#newcode47 scm/lily.scm:47: (define-public lilypond-module (resolve-module '(lily))) ;; should be equivalent to (current-module) for Guile V1.8 What is this equivalent to in GuileV2? Or rather: what module are we in if not in lily? http://codereview.appspot.com/5464045/diff/10002/scm/markup-facility-defs.scm File scm/markup-facility-defs.scm (right): http://codereview.appspot.com/5464045/diff/10002/scm/markup-facility-defs.scm#newcode92 scm/markup-facility-defs.scm:92: Use `markup*' in a \\notemode context." You are still not using the current definition of markup as your source here, correct? The doc string refers to markup*. http://codereview.appspot.com/5464045/diff/10002/scm/markup.scm File scm/markup.scm (right): http://codereview.appspot.com/5464045/diff/10002/scm/markup.scm#newcode56 scm/markup.scm:56: ;; Use `markup*' in a \\notemode context." The outcommented parts are not from the current source. Why are they outcommented instead of removed? http://codereview.appspot.com/5464045/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
