Looks nice! I have a few suggestions.
As far as running things through the formatter goes, the current formatter in git master is *not* the one that we are trying to get approved. So it shouldn't be run on current files. Thanks for your work! Carl http://codereview.appspot.com/4626094/diff/8001/lily/chord-name-engraver.cc File lily/chord-name-engraver.cc (right): http://codereview.appspot.com/4626094/diff/8001/lily/chord-name-engraver.cc#newcode177 lily/chord-name-engraver.cc:177: SCM capovertical = get_property ("capoVertical"); capovertical should be capo_vertical http://codereview.appspot.com/4626094/diff/8001/lily/chord-name-engraver.cc#newcode189 lily/chord-name-engraver.cc:189: chord_name_->set_property ("text", final_markup); I recommend that all this be done in the form of a scheme procedure, and that the scheme procedure be called. That would make it much easier to alter in the future, or for a user to customize. They can just redefine the Scheme procedure, and they are good to go. So you'd have something like chord_name->set_property ("text", scm_call_3 (chord_name_capo_proc, markup, capo_markup, capo_vertical)) http://codereview.appspot.com/4626094/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
