could we get a subject like "add a -q quiet flag to make websit scripts"
?

Also, don't mention that it includes previous patches -- that's
implicitly done everywhere in git (or any source versioning system)


http://codereview.appspot.com/4515042/diff/10001/make/website.make
File make/website.make (right):

http://codereview.appspot.com/4515042/diff/10001/make/website.make#newcode7
make/website.make:7:
IMO this stuff isn't security -- could you move it elsewhere in the
file?

Also, could you move the quiet-run = true  up so that it's in the same
"paragraph" as the commented-out stuff?  Logically, setting
quiet-run=true is a separate stage from the quiet-flag.

http://codereview.appspot.com/4515042/diff/10001/scripts/build/bib2texi.py
File scripts/build/bib2texi.py (right):

http://codereview.appspot.com/4515042/diff/10001/scripts/build/bib2texi.py#newcode63
scripts/build/bib2texi.py:63: quiet_flag = ''
the lilypond python style is to use 4 spaces per indent.

http://codereview.appspot.com/4515042/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to