Replies to Graham's comments. Not sure I've worked out how the review site does quoting yet, so apologies if this looks strange.
http://codereview.appspot.com/4515042/diff/1/make/website.make File make/website.make (right): http://codereview.appspot.com/4515042/diff/1/make/website.make#newcode8 make/website.make:8: quiet-run = $(findstring s, $(MAKEFLAGS)) On 2011/05/11 21:58:34, Graham Percival wrote: OK - I've set the boolean as true, and then set quiet flag based on the value of the boolean. However, I've left the original code there and commented, because I'm sure you'll eventually like the idea of using the -s flag :-) http://codereview.appspot.com/4515042/diff/1/make/website.make#newcode10 make/website.make:10: quiet-string=-q On 2011/05/11 21:58:34, Graham Percival wrote: I've changed it to quiet-flag http://codereview.appspot.com/4515042/diff/1/scripts/build/bib2texi.py File scripts/build/bib2texi.py (right): http://codereview.appspot.com/4515042/diff/1/scripts/build/bib2texi.py#newcode16 scripts/build/bib2texi.py:16: suppress_output = '' On 2011/05/11 21:58:34, Graham Percival wrote: OK - I've set this as a boolean and used this to set quiet-flag later on. http://codereview.appspot.com/4515042/diff/1/scripts/build/mass-link.py File scripts/build/mass-link.py (right): http://codereview.appspot.com/4515042/diff/1/scripts/build/mass-link.py#newcode16 scripts/build/mass-link.py:16: # PH note - I've just commented this out, since it's so not-helpful On 2011/05/11 21:58:34, Graham Percival wrote: Done http://codereview.appspot.com/4515042/diff/1/scripts/build/website-known-missing-files.txt File scripts/build/website-known-missing-files.txt (right): http://codereview.appspot.com/4515042/diff/1/scripts/build/website-known-missing-files.txt#newcode1 scripts/build/website-known-missing-files.txt:1: ancient-notation.itely On 2011/05/11 21:58:34, Graham Percival wrote: Yeah - that's what I said in the comment on the review. All the changes are with respect to the old base build, not my part-silent build - I guess this is because my previous change hadn't been pushed and I don't know how to create a review patch which is only the differences of the previous review patch. http://codereview.appspot.com/4515042/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
