http://codereview.appspot.com/4182056/diff/12001/Documentation/changes.tely File Documentation/changes.tely (right):
http://codereview.appspot.com/4182056/diff/12001/Documentation/changes.tely#newcode65 Documentation/changes.tely:65: New markup commands @code{\pattern} and @code{\fill-with-pattern} Please make this a full sentence. http://codereview.appspot.com/4182056/diff/12001/ly/toc-init.ly File ly/toc-init.ly (right): http://codereview.appspot.com/4182056/diff/12001/ly/toc-init.ly#newcode30 ly/toc-init.ly:30: \fill-with-pattern . #1 #RIGHT \fromproperty #'toc:text \fromproperty #'toc:page Please keep the original as default and make this an option instead. http://codereview.appspot.com/4182056/diff/12001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): http://codereview.appspot.com/4182056/diff/12001/scm/define-markup-commands.scm#newcode3403 scm/define-markup-commands.scm:3403: (define-markup-command (pattern layout props pattern count space dir) make `pattern' last arg http://codereview.appspot.com/4182056/diff/12001/scm/define-markup-commands.scm#newcode3409 scm/define-markup-commands.scm:3409: If @var{dir} is @code{CENTER}, patterns are spread horizontally. It would make more sense to use axis here (i.e., X/Y or 0/1), since there's no distinction between UP/DOWN/LEFT/RIGHT. http://codereview.appspot.com/4182056/diff/12001/scm/define-markup-commands.scm#newcode3422 scm/define-markup-commands.scm:3422: (ly:stencil-extent (interpret-markup layout props pattern) X)))) indent: (pattern-width (interval-length (ly:stencil-extent (interpret-markup layout props pattern) X)))) http://codereview.appspot.com/4182056/diff/12001/scm/define-markup-commands.scm#newcode3425 scm/define-markup-commands.scm:3425: (interpret-markup indent: (if (zero? i) (interpret-markup http://codereview.appspot.com/4182056/diff/12001/scm/define-markup-commands.scm#newcode3431 scm/define-markup-commands.scm:3431: (loop (1- i) indent (goes with (zero? i) above) http://codereview.appspot.com/4182056/diff/12001/scm/define-markup-commands.scm#newcode3434 scm/define-markup-commands.scm:3434: (markup #:column (patterns pattern #:vspace space)))))))) indent: (if (zero? dir) (markup patterns pattern #:hspace space) (markup #:column (patterns pattern #:vspace space)))))))) http://codereview.appspot.com/4182056/diff/12001/scm/define-markup-commands.scm#newcode3437 scm/define-markup-commands.scm:3437: (markup? number? ly:dir? markup? markup?) group markup args together (i.e., `pattern' before `left') http://codereview.appspot.com/4182056/diff/12001/scm/define-markup-commands.scm#newcode3472 scm/define-markup-commands.scm:3472: #:translate (cons x-offset 0) indent http://codereview.appspot.com/4182056/diff/12001/scm/define-markup-commands.scm#newcode3473 scm/define-markup-commands.scm:3473: #:pattern pattern (1+ count) space CENTER indent http://codereview.appspot.com/4182056/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
