Thanks for the feedback. I've responded to each of the suggestions
you've given me.
Carl
http://codereview.appspot.com/3832046/diff/27001/input/regression/skyline-horizontal-padding.ly
File input/regression/skyline-horizontal-padding.ly (right):
http://codereview.appspot.com/3832046/diff/27001/input/regression/skyline-horizontal-padding.ly#newcode12
input/regression/skyline-horizontal-padding.ly:12: \score {
On 2011/01/07 21:59:41, Neil Puttock wrote:
needs a \book { } block to prevent lilypond-book hijacking the
system-system
spacing
Done.
http://codereview.appspot.com/3832046/diff/27001/lily/skyline.cc
File lily/skyline.cc (right):
http://codereview.appspot.com/3832046/diff/27001/lily/skyline.cc#newcode391
lily/skyline.cc:391: {
It worked, once I changed boxes from a vector to a list.
Thanks for the insight!
http://codereview.appspot.com/3832046/diff/27001/lily/skyline.cc#newcode419
lily/skyline.cc:419: Skyline padded_skyline = Skyline (boxes,
horizon_padding, a, UP);
On 2011/01/07 16:47:27, joeneeman wrote:
This should have X_AXIS instead of "a", because you put the horizon
axis into
the X_AXIS of your boxes.
Done.
http://codereview.appspot.com/3832046/diff/27001/scm/define-grobs.scm
File scm/define-grobs.scm (right):
http://codereview.appspot.com/3832046/diff/27001/scm/define-grobs.scm#newcode1940
scm/define-grobs.scm:1940: (skyline-horizontal-padding . 2)
On 2011/01/07 23:53:34, Keith wrote:
too big for a default. I suggest 0.5.
A horizontal space of _4-times_ this value is maintained between
potential
interleavers, because the diagonal starts one padding a way from the
grob, the
vertical is two paddings away, and grobs from each system are padded.
I realize that a value of 1.5 or greater is required to affect your
regression
test, but an \override in the score would make a more useful
regression test
anyway.
The only musical example I have seen where I would want the padding is
the
regtest les-nereides.ly, which greatly improved with
horizontal-padding 0.5.
Done. 0.5 also works fine with stem-length-estimation.ly.
http://codereview.appspot.com/3832046/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
