hi Neil, >> updated the patch fixing the issue and attached >> an example where the previous version failed. > > LGTM. > > A few minor nitpicks: > > + /* > + note that note_dur may be strictly less than left_to_do_ > + (say, if left_to_do_ == 5/8) > + */ > > This comment would be better placed first in this block. > > +++ b/input/regression/completion-heads-polyphony-complex.ly > > This test is very similar to the existing one, so it would be fine to > call it completion-heads-polyphony-2.ly. > > +\version "2.12.0" > > "2.13.22" > > +Complex completion heads may be fooled by polyphony with a different rhythm. > > Please change this to something which explains that the polyphony in > this test works properly.
what about "Versions up to 2.13.21 got complex completion heads wrong in polyphonic environment"? thanks for all the suggestions; I agree with all and will do it, but only in June, as my computer broke. p _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
