On Sun, Jan 31, 2010 at 8:34 PM, Graham Percival
<[email protected]> wrote:
> On Sun, Jan 31, 2010 at 07:38:42PM +0000, Neil Puttock wrote:
>> On 31 January 2010 17:59, Jean-Charles Malahieude <[email protected]> wrote:
>>
>> > It might help to keep in mind that the documentation is produced in 7 other
>> > languages than English.  There is then 1 instance missing?
>>
>> No, it's surely a bug (if it's not, it's a ridiculous change :).
>> There should only be one instance of the options per file.
>
> I thought Jean-Charles' comment was a useful hint for debugging:
> check to see if it's the translations that's breaking it.  For
> example, if we do a local-doc build in Documentation, will there
> only be one set of options, or many?

There are many options even when running `lilypond-book' standalone,
outside the build tree.

> I missed the chance to do such investigations today, but I'll try
> to do a bit during the week.  I'll postpone 2.13.12 until this is
> fixed.
> (actually, I should check the docs for 2.13.11 and earlier: did
> they have the same problem?)

Yes, the 2.13.11 docs are affected.  The behavior changed with John's
commit c258b7.

The attached patch significantly reduces the number of options, but I
don't know if this is the output John was originally intending for.

Thanks,
Patrick
diff --git a/scripts/lilypond-book.py b/scripts/lilypond-book.py
index ac3969c..1f8a010 100644
--- a/scripts/lilypond-book.py
+++ b/scripts/lilypond-book.py
@@ -1205,7 +1205,7 @@ left-margin-default right-margin-default)"
         option_list = []
         for option in self.get_option_list ():
             for name in PROCESSING_INDEPENDENT_OPTIONS:
-                if not option.startswith (name):
+                if option.startswith (name):
                     option_list.append (option)
         option_string = ','.join (option_list)
 
_______________________________________________
lilypond-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to