Hi Reinhold, This looks OK, but I don't think you need to use a list any more.
Cheers, Neil http://codereview.appspot.com/174080/diff/1003/1004 File lily/tie-performer.cc (right): http://codereview.appspot.com/174080/diff/1003/1004#newcode34 lily/tie-performer.cc:34: Head_audio_event_tuple () { } {} http://codereview.appspot.com/174080/diff/1003/1004#newcode46 lily/tie-performer.cc:46: // We don't really need a list or deque here. A vector would suffice. However, Remove all this? Since the error was caused by a naming conflict for the struct, you can use a vector now, though it's less convenient for removing the tied heads. http://codereview.appspot.com/174080/diff/1003/1004#newcode89 lily/tie-performer.cc:89: // for each tied note, store the info and its end moment, so we can trailing space http://codereview.appspot.com/174080/diff/1003/1004#newcode90 lily/tie-performer.cc:90: // later on check whether (1) the note is still ongoing and (2) how trailing space http://codereview.appspot.com/174080/diff/1003/1004#newcode103 lily/tie-performer.cc:103: for ( it = heads_to_tie_.begin() ; (!found) && (it != heads_to_tie_.end()); it++ ) indentation for (it = heads_to_tie_.begin (); !found && (it != heads_to_tie_.end ()); it++;) http://codereview.appspot.com/174080/diff/1003/1004#newcode133 lily/tie-performer.cc:133: class end_moment_passed indentation: { protected: Moment now; etc. http://codereview.appspot.com/174080/diff/1003/1004#newcode139 lily/tie-performer.cc:139: bool operator() (const Head_audio_event_tuple& value) {return (value.end_moment_ <= now); } bool operator() (const Head_audio_event_tuple &value) { return (value.end_moment_ <= now); } http://codereview.appspot.com/174080/diff/1003/1004#newcode155 lily/tie-performer.cc:155: heads_to_tie_.splice (heads_to_tie_.end(), now_heads_); heads_to_tie_.end () http://codereview.appspot.com/174080/diff/1003/1004#newcode157 lily/tie-performer.cc:157: heads_to_tie_.splice (heads_to_tie_.end(), now_tied_heads_); heads_to_tie_.end () http://codereview.appspot.com/174080 _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
