http://codereview.appspot.com/143055/diff/10/1005
File ly/init.ly (right):
http://codereview.appspot.com/143055/diff/10/1005#newcode14
Line 14: #(define toplevel-bookparts (list))
On 2009/10/29 21:14:17, Neil Puttock wrote:
trailing space
Done.
http://codereview.appspot.com/143055/diff/10/1006
File ly/music-functions-init.ly (left):
http://codereview.appspot.com/143055/diff/10/1006#oldcode182
Line 182:
On 2009/10/29 21:14:17, Neil Puttock wrote:
restore
These spaces were added when the file was sorted alphabetically.
Done.
http://codereview.appspot.com/143055/diff/10/1006#oldcode183
Line 183:
On 2009/10/29 21:14:17, Neil Puttock wrote:
restore
Done.
http://codereview.appspot.com/143055/diff/10/1006
File ly/music-functions-init.ly (right):
http://codereview.appspot.com/143055/diff/10/1006#newcode17
Line 17: #(define (void-make-music)
On 2009/10/29 21:14:17, Neil Puttock wrote:
Like Carl's said, it's fine leaving this for another patch.
A few pointers:
For consistency with the other helper functions, it should be named
make-void-music
It should go in music-functions.scm
It should be define-public
Done. (left as a TODO: for future patch)
http://codereview.appspot.com/143055/diff/10/1006#newcode176
Line 176: 'delta-step delta))
On 2009/10/29 21:14:17, Neil Puttock wrote:
should be aligned with 'BendAfterEvent
Done.
http://codereview.appspot.com/143055/diff/10/1006#newcode180
Line 180: (_i "Direct output for the current book block to
@var{newfilename}")
On 2009/10/29 21:14:17, Neil Puttock wrote:
full stop after @var{newfilename}
Done.
http://codereview.appspot.com/143055/diff/10/1006#newcode187
Line 187: @var{newsuffix}")
On 2009/10/29 21:14:17, Neil Puttock wrote:
full stop after @var{newsuffix}
Done.
http://codereview.appspot.com/143055
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
