Carl gave some feedback via e-mail. I've recorded them here before uploading a patch set.
Ian http://codereview.appspot.com/143055/diff/1/5 File scm/lily-library.scm (right): http://codereview.appspot.com/143055/diff/1/5#newcode162 Line 162: (let* ( (base-name (get-current-filename parser)) remove space between ( ( after let* http://codereview.appspot.com/143055/diff/1/5#newcode170 Line 170: (set! result (format "~a-~a" set! statement needs reformatting and indenting (feedback from Carl) (set! result (format "~a-~a" result (string-regexp-substitute "[^-[:alnum:]]" "_" output-suffix)))) http://codereview.appspot.com/143055/diff/1/5#newcode175 Line 175: (if (> output-count 0) if block needs indenting correctly - (feedback from Carl) (if (> output-count 0) (set! result (format #f "~a-~a" result output-count) http://codereview.appspot.com/143055 _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
