http://codereview.appspot.com/88155/diff/3101/4027 File input/new/grouping-beats.ly (right):
http://codereview.appspot.com/88155/diff/3101/4027#newcode7 Line 7: Beaming patterns may be altered with the @code{beatGrouping} property: new texidoc using \overrideBeamSettings http://codereview.appspot.com/88155/diff/3101/4032 File lily/beam-scheme.cc (right): http://codereview.appspot.com/88155/diff/3101/4032#newcode10 Line 10: #include "beam-grouping.hh" swap http://codereview.appspot.com/88155/diff/3101/4032#newcode26 Line 26: " @var{rule-type} in @var{context}.") no context arg, doc settings http://codereview.appspot.com/88155/diff/3101/4032#newcode28 Line 28: LY_ASSERT_TYPE (ly_is_pair, time_signature, 2); scm_is_pair http://codereview.appspot.com/88155/diff/3101/4032#newcode30 Line 30: type check also for settings? http://codereview.appspot.com/88155/diff/3101/4032#newcode34 Line 34: ly_assoc_get ((scm_list_2 (time_signature, rule_type)), excess parens http://codereview.appspot.com/88155/diff/3101/4032#newcode43 Line 43: "Return grouping for beams of @var{ beam-type} in" @var{beam-type} http://codereview.appspot.com/88155/diff/3101/4032#newcode45 Line 45: " @var{rule-type} in @var{context}.") no context arg, doc settings http://codereview.appspot.com/88155/diff/3101/4032#newcode46 Line 46: { type checks? http://codereview.appspot.com/88155/diff/3101/4032#newcode57 Line 57: { LY_ASSERT_SMOB (Context, context, 1); If you don't do this, then unsmob_context () will return NULL if this function is passed invalid arguments, leading to a null dereference for get_property ("timeSignatureFraction") -> segfault http://codereview.appspot.com/88155/diff/3101/4033 File lily/beaming-pattern.cc (right): http://codereview.appspot.com/88155/diff/3101/4033#newcode18 Line 18: #include "beam-grouping.hh" sort http://codereview.appspot.com/88155/diff/3101/4034 File lily/include/beam-grouping.hh (right): http://codereview.appspot.com/88155/diff/3101/4034#newcode8 Line 8: To prevent multiple includes: #ifndef BEAM_GROUPING_HH #define BEAM_GROUPING_HH (+ line 14) http://codereview.appspot.com/88155/diff/3101/4034#newcode14 Line 14: #endif // BEAM_GROUPING_HH http://codereview.appspot.com/88155/diff/3101/4035 File lily/measure-grouping-engraver.cc (right): http://codereview.appspot.com/88155/diff/3101/4035#newcode14 Line 14: #include "beam-grouping.hh" sort http://codereview.appspot.com/88155/diff/3101/4035#newcode66 Line 66: SCM time_signature_fraction = get_property ("timeSignatureFraction"); move to if { } block, then it's only retrieved if required http://codereview.appspot.com/88155/diff/3101/4038 File ly/music-functions-init.ly (right): http://codereview.appspot.com/88155/diff/3101/4038#newcode20 Line 20: (_i "Define @@var{music} as a quotable music expression named rogue extra @'s throughout file http://codereview.appspot.com/88155/diff/3101/4039 File python/convertrules.py (right): http://codereview.appspot.com/88155/diff/3101/4039#newcode2930 Line 2930: str = re.sub("\\set\w+#\'beatGrouping", "\\setBeatGrouping", str) won't get here due to search above (and regexp is broken) http://codereview.appspot.com/88155/diff/3101/4041 File scm/beam-settings.scm (right): http://codereview.appspot.com/88155/diff/3101/4041#newcode48 Line 48: ;; in 3 4 time: decided not to restore original setting? http://codereview.appspot.com/88155/diff/3101/4041#newcode155 Line 155: ;;;; Functions for overriding beam settings indentation of function bodies http://codereview.appspot.com/88155/diff/3101/4043 File scm/define-context-properties.scm (right): http://codereview.appspot.com/88155/diff/3101/4043#newcode126 Line 126: (beatGrouping ,list? "A list of beatgroups, e.g., in 5/8 time remove http://codereview.appspot.com/88155 _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
