Reviewers: Neil Puttock, joeneeman,
Message:
OK, I've responded to Joe's comments.
I've created a new file lily/beam-scheme.cc, and put c++ and scheme
callable routines in it. Then I've used those calls from auto-beam.scm,
measure-grouping-engraver.cc, and beaming-pattern.cc. I also added a
new file lily/include/beam-grouping.hh to provide those functions to
c++.
I've never done this much mucking in the c++ code before, so please make
sure I've done things right.
Thanks,
Carl
http://codereview.appspot.com/88155/diff/3092/2039
File ly/music-functions-init.ly (right):
http://codereview.appspot.com/88155/diff/3092/2039#newcode699
Line 699: (make-music 'SequentialMusic 'void #t))
On 2009/07/21 18:24:35, joeneeman wrote:
I'd feel better if this were finished. At least add FIXME so it can be
easily
grepped for.
OK -- fixed in new patch set.
http://codereview.appspot.com/88155/diff/3092/2047
File scm/music-functions.scm (right):
http://codereview.appspot.com/88155/diff/3092/2047#newcode546
Line 546: (define (make-default-beaming-rule context)
On 2009/07/21 18:24:35, joeneeman wrote:
this doesn't seem to be used...
Thanks for the catch -- removed
Description:
New format for autobeaming rules
Change autobeaming rules so they are all set in one place and they
remain if the time signature is changed.
Eliminates override-auto-beam-settings and revert-auto-beam-settings
autoBeamSettings property changed to beamSettings property
beatGrouping property eliminated (default autobeam rule is now
used for beatGrouping)
Please review this at http://codereview.appspot.com/88155
Affected files:
M Documentation/de/user/rhythms.itely
M Documentation/es/user/rhythms.itely
M Documentation/fr/user/rhythms.itely
M Documentation/topdocs/NEWS.tely
M Documentation/user/music-glossary.tely
M Documentation/user/rhythms.itely
M input/lsr/automatic-beams-two-per-two-in-4-4-or-2-2-time-signature.ly
M input/lsr/beam-endings-in-score-context.ly
M input/lsr/beam-grouping-in-7-8-time.ly
M input/lsr/chordchanges-for-fretboards.ly
M input/lsr/compound-time-signatures.ly
M input/lsr/conducting-signs,-measure-grouping-signs.ly
M input/lsr/grouping-beats.ly
M input/lsr/making-slurs-with-complex-dash-structure.ly
M input/lsr/non-default-tuplet-numbers.ly
M input/lsr/non-traditional-key-signatures.ly
M input/lsr/reverting-default-beam-endings.ly
M input/manual/fretted-headword.ly
M input/mutopia/claop.py
A input/new/beam-endings-in-score-context.ly
A input/new/beam-grouping-in-7-8-time.ly
A input/new/compound-time-signatures.ly
A input/new/conducting-signs,-measure-grouping-signs.ly
A input/new/grouping-beats.ly
A input/new/reverting-default-beam-endings.ly
M input/regression/auto-beam-beat-grouping.ly
M input/regression/beam-beat-grouping.ly
M lily/auto-beam-engraver.cc
A lily/beam-scheme.cc
M lily/beaming-pattern.cc
A lily/include/beam-grouping.hh
M lily/measure-grouping-engraver.cc
M ly/bagpipe.ly
M ly/engraver-init.ly
M ly/music-functions-init.ly
M python/convertrules.py
M scm/auto-beam.scm
A scm/beam-settings.scm
M scm/c++.scm
M scm/define-context-properties.scm
M scm/define-music-display-methods.scm
M scm/lily.scm
M scm/music-functions.scm
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
