http://codereview.appspot.com/88155/diff/43/1044 File Documentation/user/rhythms.itely (right):
http://codereview.appspot.com/88155/diff/43/1044#newcode1662 Line 1662: of the beam, e.g. @code{#'(1 . 16)}, or @code{#'*} to indicate a This could be confusing to users unfamiliar with Scheme, since it implies the hash and quote are required inside the alist. http://codereview.appspot.com/88155/diff/43/1045 File input/lsr/automatic-beams-two-per-two-in-4-4-or-2-2-time-signature.ly (right): http://codereview.appspot.com/88155/diff/43/1045#newcode1 Line 1: %% Do not edit this file; it is auto-generated from input/new If you're keeping the revised rule for 4/4, this file's obsolete (it's already been unticked in LSR for docs). The changes you've made contradict the original intent of this snippet (and the title's incorrect), so it would be better to have a new snippet for this. Frankly, I'd much prefer returning to the old settings (also for 3/4); not only are they more in keeping with LilyPond's declared aims with regard to typesetting style, they also produce better looking examples in the documentation. http://codereview.appspot.com/88155/diff/43/1045#newcode53 Line 53: } % begin verbatim There should only be one of these inserted automatically (as above, at the closing brace for the header). http://codereview.appspot.com/88155/diff/43/1046 File input/lsr/beam-endings-in-score-context.ly (right): http://codereview.appspot.com/88155/diff/43/1046#newcode57 Line 57: } % begin verbatim rogue %begin verbatim http://codereview.appspot.com/88155/diff/43/1047 File input/lsr/beam-grouping-in-7-8-time.ly (right): http://codereview.appspot.com/88155/diff/43/1047#newcode57 Line 57: } % begin verbatim rogue %begin verbatim http://codereview.appspot.com/88155/diff/43/1049 File input/lsr/compound-time-signatures.ly (right): http://codereview.appspot.com/88155/diff/43/1049#newcode75 Line 75: } % begin verbatim rogue %begin verbatim http://codereview.appspot.com/88155/diff/43/1050 File input/lsr/conducting-signs,-measure-grouping-signs.ly (right): http://codereview.appspot.com/88155/diff/43/1050#newcode88 Line 88: } % begin verbatim rogue %begin verbatim http://codereview.appspot.com/88155/diff/43/1051 File input/lsr/grouping-beats.ly (right): http://codereview.appspot.com/88155/diff/43/1051#newcode49 Line 49: } % begin verbatim rogue %begin verbatim http://codereview.appspot.com/88155/diff/43/1055 File input/lsr/reverting-default-beam-endings.ly (right): http://codereview.appspot.com/88155/diff/43/1055#newcode59 Line 59: } % begin verbatim rogue %begin verbatim http://codereview.appspot.com/88155/diff/43/1060 File lily/measure-grouping-engraver.cc (right): http://codereview.appspot.com/88155/diff/43/1060#newcode65 Line 65: SCM time_signature_fraction = get_property("timeSignatureFraction"); get_property ( http://codereview.appspot.com/88155/diff/43/1060#newcode69 Line 69: remove blank line http://codereview.appspot.com/88155/diff/43/1060#newcode74 Line 74: scm_from_locale_string ("end"))), ly_symbol2scm ("end") http://codereview.appspot.com/88155/diff/43/1060#newcode77 Line 77: scm_from_locale_string ("*")), ly_symbol2scm ("*") http://codereview.appspot.com/88155/diff/43/1067 File scm/c++.scm (right): http://codereview.appspot.com/88155/diff/43/1067#newcode34 Line 34: (or (number? x) (symbol? x))) unused? http://codereview.appspot.com/88155 _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
