Daniel Reed wrote:
On 2004-08-12T00:30+0900, Peter O'Gorman wrote:
) > ) >   >   libtool-1.4-nonneg.patch
) > ) ) >   >   libtool-1.5-libtool.m4-x86_64.patch
) > ) This too.
) Aw, with changelog entries and stuff :)

The entry for libtool-1.4-nonneg.patch in the RPM changelog is:

* Thu Jul 13 2000 Elliot Lee <[EMAIL PROTECTED]>
- Fix recognition of ^0[0-9]+$ as a non-negative integer.

After I went to bed, I realized that this patch was not correct. It allows non-numeric strings in the version info, as long as the first digit is numeric. However the current code is only checking for 3 digits or less, so perhaps we simply need to change it to something like:


case $current in
        *[!0-9]*)
          $echo "$modename: CURRENT \`$current' is not a nonnegative integer" 1>&2
          $echo "$modename: \`$vinfo' is not valid version information" 1>&2
        ;;
esac
etc... ?



This may just be my inexperience with Libtool's code, but it appears that section is [now?] always setting lt_cv_deplibs_check_method to pass_all:

Looks like this should just be: linux*) lt_cv_deplibs_check_method=pass_all ;;

As you say. It is simply confusing to have stuff override stuff in there. It is in HEAD as well as branch-1-5. I'll remove it after work.


Thanks, Peter -- Peter O'Gorman - http://www.pogma.com


_______________________________________________ Libtool mailing list [EMAIL PROTECTED] http://lists.gnu.org/mailman/listinfo/libtool

Reply via email to