-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Ileana Dumitrescu wrote:
> On 23/10/2025 16:16, KO Myung-Hun wrote:
>> Ping?
>>
>> KO Myung-Hun wrote:
>>> old_archive_from_new_cmds is not used at all. In addition, if
>>> this is defined static libs are not generated.
>>>
>>> This is a regression of commit e60044.
>>>
>>> * m4/libtool.m4: Do not define old_archive_from_new_cmds on
>>> OS/2. --- m4/libtool.m4 | 6 +++--- 1 file changed, 3
>>> insertions(+), 3 deletions(-)
>>>
>>> diff --git a/m4/libtool.m4 b/m4/libtool.m4 index
>>> 18c5fbcd..ea2c1808 100644 --- a/m4/libtool.m4 +++
>>> b/m4/libtool.m4 @@ -5313,7 +5313,7 @@ _LT_EOF cat
>>> $export_symbols | $prefix_cmds >> $output_objdir/$libname.def~
>>> $CC -Zdll -Zcrtdll -o $output_objdir/$soname $libobjs $deplibs
>>> $compiler_flags $output_objdir/$libname.def~ emximp -o $lib
>>> $output_objdir/$libname.def' -
>>> _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def' +
>>> #_LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
>>> _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
>>> _LT_TAGVAR(file_list_spec, $1)='@' ;; @@ -6029,7 +6029,7 @@
>>> _LT_EOF cat $export_symbols | $prefix_cmds >>
>>> $output_objdir/$libname.def~ $CC -Zdll -Zcrtdll -o
>>> $output_objdir/$soname $libobjs $deplibs $compiler_flags
>>> $output_objdir/$libname.def~ emximp -o $lib
>>> $output_objdir/$libname.def' -
>>> _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def' +
>>> #_LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
>>> _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
>>> _LT_TAGVAR(file_list_spec, $1)='@' ;; @@ -6902,7 +6902,7 @@ if
>>> test yes != "$_lt_caught_CXX_error"; then cat $export_symbols |
>>> $prefix_cmds >> $output_objdir/$libname.def~ $CC -Zdll -Zcrtdll
>>> -o $output_objdir/$soname $libobjs $deplibs $compiler_flags
>>> $output_objdir/$libname.def~ emximp -o $lib
>>> $output_objdir/$libname.def' -
>>> _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def' +
>>> #_LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
>>> _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
>>> _LT_TAGVAR(file_list_spec, $1)='@' ;;
>
> Thank you for your patch! Sorry for not replying sooner, it was
> not delivered to my inbox. I think the lines should be removed
> instead of commented out if they are not needed. Can I apply your
> patch header with the lines removed?
>
Here is the missed patch.
- --
KO Myung-Hun
Korean OS/2 User Community : https://www.os2.kr/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (OS/2)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIVAwUBaP2uc7bToKI+6WqcAQKMYxAAl5X6a5yAx6ZjjzIPi/c6KRAUq+jlzvFM
XjkcsZ11AOAQE9a3Vy/hIw8qiZ0bARUFw+S9Tz+npgXyGYBbzldecGim4Gc2F+YM
oUVEh8cyEujTIXjveafE2Jj5+FfeNy1i2/O0x+r2ux9IMgGENX4sI2k7zxxE+6Au
rK3/NUn8bLoeNMvWupGtxjyBfop+R5ZGjfvhecW89A79SNvoEEb3ardKBwr2mP8/
2ro5bH6A1wNPeEDqKJXw+ayM9SEddgwDxJlcJd72YtHyu3RIjNZOas0DmzEntsVj
tJIG0AkqzilB0ATxdDNdmyDAqFjbGQsekdFoHLFlbdCpzxbnjZj5ICf80LSZI5QU
RPJgV9XGUmhQ54EXkgVMMdRdhhN8sSAa+AcIsRi+XTnJtU+jElAHUba00XoG9SuN
iNjMrZDCFBoHlbhyNpAcnlt3WRq8sBSFbL5LVgAW6OV6r/XWzwWJe3ylcEguULY/
2lpM/85fIxjiGQ0ZSkOFNcPGyFzOy395C/2EOrIQIHqKQer1RjWIkJD+1Emt4OCm
RVn8h0Z0YAOb2hKs6j+5zB6xPUkk/f35vLhWurN7+oYuc05iUGxcR676KWiaiCzh
nTMZ08kQzFSNFsfXuZ7VjYIdx0pnL7X+d2ORuYPuHC9nLk5USQHrbu2+pTNS6oGB
CO0R6r3JvUo=
=qpAu
-----END PGP SIGNATURE-----
From 052619a6fd2a4582ae159575b5b447ee49394e92 Mon Sep 17 00:00:00 2001
From: KO Myung-Hun <[email protected]>
Date: Sun, 9 Feb 2025 23:23:30 +0900
Subject: [PATCH] libtool: Remove old_archive_from_new_cmds on OS/2
old_archive_from_new_cmds is not used at all. In addition, if this is
defined static libs are not generated.
This is a regression of commit e60044.
* m4/libtool.m4: Remove old_archive_from_new_cmds on OS/2.
---
m4/libtool.m4 | 3 ---
1 file changed, 3 deletions(-)
diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 219efd68..306c2bbb 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -5408,7 +5408,6 @@ _LT_EOF
cat $export_symbols | $prefix_cmds >> $output_objdir/$libname.def~
$CC -Zdll -Zcrtdll -o $output_objdir/$soname $libobjs $deplibs $compiler_flags $output_objdir/$libname.def~
emximp -o $lib $output_objdir/$libname.def'
- _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
_LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
_LT_TAGVAR(file_list_spec, $1)='@'
;;
@@ -6130,7 +6129,6 @@ _LT_EOF
cat $export_symbols | $prefix_cmds >> $output_objdir/$libname.def~
$CC -Zdll -Zcrtdll -o $output_objdir/$soname $libobjs $deplibs $compiler_flags $output_objdir/$libname.def~
emximp -o $lib $output_objdir/$libname.def'
- _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
_LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
_LT_TAGVAR(file_list_spec, $1)='@'
;;
@@ -7009,7 +7007,6 @@ if test yes != "$_lt_caught_CXX_error"; then
cat $export_symbols | $prefix_cmds >> $output_objdir/$libname.def~
$CC -Zdll -Zcrtdll -o $output_objdir/$soname $libobjs $deplibs $compiler_flags $output_objdir/$libname.def~
emximp -o $lib $output_objdir/$libname.def'
- _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
_LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
_LT_TAGVAR(file_list_spec, $1)='@'
;;
--
2.50.1
