-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Ileana Dumitrescu wrote:
> On 23/10/2025 16:16, KO Myung-Hun wrote:
>> Ping?
>>
>> KO Myung-Hun wrote:
>>> old_archive_from_new_cmds is not used at all. In addition, if
>>> this is defined static libs are not generated.
>>>
>>> This is a regression of commit e60044.
>>>
>>> * m4/libtool.m4: Do not define old_archive_from_new_cmds on
>>> OS/2. --- m4/libtool.m4 | 6 +++--- 1 file changed, 3
>>> insertions(+), 3 deletions(-)
>>>
>>> diff --git a/m4/libtool.m4 b/m4/libtool.m4 index
>>> 18c5fbcd..ea2c1808 100644 --- a/m4/libtool.m4 +++
>>> b/m4/libtool.m4 @@ -5313,7 +5313,7 @@ _LT_EOF cat
>>> $export_symbols | $prefix_cmds >> $output_objdir/$libname.def~
>>> $CC -Zdll -Zcrtdll -o $output_objdir/$soname $libobjs $deplibs
>>> $compiler_flags $output_objdir/$libname.def~ emximp -o $lib
>>> $output_objdir/$libname.def' -
>>> _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def' +
>>> #_LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
>>> _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
>>> _LT_TAGVAR(file_list_spec, $1)='@' ;; @@ -6029,7 +6029,7 @@
>>> _LT_EOF cat $export_symbols | $prefix_cmds >>
>>> $output_objdir/$libname.def~ $CC -Zdll -Zcrtdll -o
>>> $output_objdir/$soname $libobjs $deplibs $compiler_flags
>>> $output_objdir/$libname.def~ emximp -o $lib
>>> $output_objdir/$libname.def' -
>>> _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def' +
>>> #_LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
>>> _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
>>> _LT_TAGVAR(file_list_spec, $1)='@' ;; @@ -6902,7 +6902,7 @@ if
>>> test yes != "$_lt_caught_CXX_error"; then cat $export_symbols |
>>> $prefix_cmds >> $output_objdir/$libname.def~ $CC -Zdll -Zcrtdll
>>> -o $output_objdir/$soname $libobjs $deplibs $compiler_flags
>>> $output_objdir/$libname.def~ emximp -o $lib
>>> $output_objdir/$libname.def' -
>>> _LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def' +
>>> #_LT_TAGVAR(old_archive_from_new_cmds, $1)='emximp -o
>>> $output_objdir/${libname}_dll.a $output_objdir/$libname.def'
>>> _LT_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
>>> _LT_TAGVAR(file_list_spec, $1)='@' ;;
>
> Thank you for your patch! Sorry for not replying sooner, it was
> not delivered to my inbox. I think the lines should be removed
> instead of commented out if they are not needed. Can I apply your
> patch header with the lines removed?
>
Sure. Thanks!
- --
KO Myung-Hun
Korean OS/2 User Community : https://www.os2.kr/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (OS/2)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIVAwUBaPzZrbbToKI+6WqcAQKyfg/9GcIlXZbWOvY4p6n1fCNiyfbZ89n+haic
oYTWvim6vaioSWCuA5Z4KvGBVym8JhYn73onTsxJpBSFlw4afOdu4mbIo+z4HXRf
SobECyfS8gzfmdNvRYEHQCyaEx8KOEfl1fdsRTDNEV0Aag4GA/J8Pt6z5+5I7SMQ
MHIsMfxerDKjwMAhRnRXZ1IdCCCgcSYdvGDQYz9ZtHnAJlaT1821igzB4mn9u2Xd
Iu3oxFnQaHB8xT+u2Zm0R26cjhNnJ+dUh+zTuHtafx+ZBMSjTsjHAS/L1rA4jQ6r
wYnci6GJXfpVdLWN8ZJQl9Q2Gjgc0ITGRgJB5vulYmde2KEyzyDZnNndbykHGG0h
NLPv48u4cHSsX4Th4v2nAIfubKoihtZyLH6ytDMZKyLh1dUBRQVVGHa1LNEWSPGy
TYutbZJMiTTtZ2ABOdtx1eJERQZfKF4HJIkOxuF6JPxYrtPYy7941kQmF56E5Odd
YLSmnBzqH57oxvpU85JzaZ9Pul6vg/dLGw3KvcePcT6ngwvdcHpcutzEw8OecnWe
8VHhfg5JYd8ZDBb9kcMbqfFUKbPtX9Ru/Wod5Kctts+W7wS9Y8Kp6VeSh1+O7AKT
Pm+XVs30MV359DVMf20sFoMk/dPxe8EY4z8MyOFkH06ug6KScPIztbrCKeth1f+m
vsBdxnYe64A=
=key1
-----END PGP SIGNATURE-----
