On 02/11/2011 11:10 AM, Peter O'Gorman wrote:
On 02/11/2011 10:52 AM, Křištof Želechovski wrote:
libtool.x86_64: W: script-without-shebang
/usr/share/libtool/config/ltmain.sh
This text file has executable bits set or is located in a path
dedicated for
executables, but lacks a shebang and cannot thus be executed. If the
file is
meant to be an executable script, add the shebang, otherwise remove the
executable bits or move the file elsewhere.
Yeah, it's not meant to be executed as is, I guess it was easier to
install it with the same rule as every other file in that dir.
I would say it is easier to install it with permissions matching its
status. What is easier depends on your POV. In the end, what is easier
to the customer should prevail because there are more customers than
developers.
I'll look into this.
This passed all tests and make distcheck, I am pretty sure that nothing
requires ltmain to be executable, but just in case someone knows better,
I'm asking for approval :)
Ok?
Peter
>From c44468e0ec23e4b72f1e37e98be23ae71b6d0ed1 Mon Sep 17 00:00:00 2001
From: Peter O'Gorman <pe...@pogma.com>
Date: Mon, 14 Feb 2011 10:34:58 -0600
Subject: [PATCH] Install ltmain.sh without execute bit set.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* Makefile.am: change install rule for ltmain.sh
Reported by KÅiÅ¡tof Želechovski.
---
ChangeLog | 6 ++++++
Makefile.am | 3 ++-
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 6e89fa8..7f74eab 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2011-02-12 Peter O'Gorman <pe...@pogma.com>
+
+ Install ltmain.sh without execute bit set.
+ * Makefile.am: change install rule for ltmain.sh
+ Reported by KÅiÅ¡tof Želechovski.
+
2011-02-07 Ralf Wildenhues <ralf.wildenh...@gmx.de>
docs: fix copyright years in PDF version of the manual.
diff --git a/Makefile.am b/Makefile.am
index f0590a8..268b399 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -393,10 +393,11 @@ install-data-local: libltdl/Makefile.in
## install the helper scripts
$(mkinstalldirs) $(DESTDIR)$(pkgdatadir)
$(mkinstalldirs) $(DESTDIR)$(pkgdatadir)/config
- @list='$(auxfiles)' && for p in $$list; do \
+ @list='$(auxexefiles)' && for p in $$list; do \
echo " $(INSTALL_SCRIPT) '$(srcdir)/libltdl/$$p' '$(DESTDIR)$(pkgdatadir)/$$p'"; \
$(INSTALL_SCRIPT) "$(srcdir)/libltdl/$$p" "$(DESTDIR)$(pkgdatadir)/$$p"; \
done
+ $(INSTALL_DATA) "$(srcdir)/libltdl/config/ltmain.sh" "$(DESTDIR)$(pkgdatadir)/config/ltmain.sh"
## install the libltdl files
$(mkinstalldirs) $(DESTDIR)$(pkgdatadir)/libltdl
$(mkinstalldirs) $(DESTDIR)$(pkgdatadir)/libltdl/libltdl
--
1.7.3.4
