On 06/11/2010 11:53 AM, Dave Korn wrote:
On 11/06/2010 16:18, Peter O'Gorman wrote:
Hello Dave,
The bindir.at test fails when libtool is configured with
--disable-shared, I am considering just skipping the test in that case,
but if the test is still useful, then perhaps we can change the check so
that it tests for .lib or .a files?
Hi Peter,
The test verifies that shared libraries (DLLs) are installed into the
location specified by --bindir. The option isn't meant to do anything to
anything else, so without shared libs, there's nothing to check; skipping it
seems like the most straightforward approach. Sorry for not having thought of
this when I sent the patch in the first place!
Thanks, I pushed this.
Peter
>From d4558ac9bee7bde487ea982c28771d43a610d4fc Mon Sep 17 00:00:00 2001
From: Peter O'Gorman <pe...@pogma.com>
Date: Fri, 11 Jun 2010 14:22:55 -0500
Subject: [PATCH] Skip bindir install test if we're not building shared.
* tests/bindir.at: Skip install test if necessary.
* THANKS: Update.
Report by Michael E Faenza.
---
ChangeLog | 7 +++++++
THANKS | 1 +
tests/bindir.at | 3 +++
3 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 48b26f8..823c6d3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2010-06-11 Peter O'Gorman <pe...@pogma.com>
+
+ Skip bindir install test if we're not building shared.
+ * tests/bindir.at: Skip install test if necessary.
+ * THANKS: Update.
+ Report by Michael E Faenza.
+
2010-06-11 Gary V. Vaughan <g...@gnu.org>
Use getopt.m4sh to generate libtoolize option parser.
diff --git a/THANKS b/THANKS
index dc61c43..08445f1 100644
--- a/THANKS
+++ b/THANKS
@@ -130,6 +130,7 @@
Marcel Loose lo...@astron.nl
Mark Kettenis kette...@phys.uva.nl
Matthijs Kooijman matth...@stdin.nl
+ Micheal E. Faenza mfae...@mitre.org
Michael Haubenwallner michael.haubenwall...@salomon.at
Mike Gorchak m...@malva.ua
Mike Frysinger vap...@gentoo.org
diff --git a/tests/bindir.at b/tests/bindir.at
index e49853d..40e67cc 100644
--- a/tests/bindir.at
+++ b/tests/bindir.at
@@ -198,6 +198,9 @@ case "$host_os" in
;;
esac
+eval "`$LIBTOOL --config | grep '^build_libtool_libs='`"
+AT_CHECK([test "$build_libtool_libs" = yes || (exit 77)])
+
####
# These routines save the PATH before a test and restore it after,
# prepending a chosen directory to the path on the platforms where
--
1.7.0.1
