On Tuesday 29 of July 2014, Michael Stahl wrote: > On 29/07/14 01:39, V wrote: > > The only thing bugging me is that the extern-and-not-defined plugin is > > not really werror compatible because it seems to warn in a lot of > > places. To disable it I moved into a "disabled" folder and told git to > > ignore it so I dont commit that changed, but it seems to reappear > > everytime I pull. > > interesting ... i've had the same problem with 2 of the clang plugins; > at least with the clang packages on Fedora 20, they report warnings in > _header_ files despite the plugins having a check that the offending > statement "isInMainFile()" - perhaps it's some clang bug that does not > occur with the clang versions the authors of the plugins used? well > there is macro expansion involved in the problems i saw, argh...
I think the call to isInMainFile() should not use spellingLocation, but just the location given by functionDecl->getLocation() . -- Lubos Lunak l.lu...@collabora.com _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice