core.git: 3 commits - sal/osl sw/source

[Caolán McNamara (via logerrit)]

 sal/osl/unx/profile.cxx          |    3 ++-
 sw/source/core/fields/fldbas.cxx |    1 +
 sw/source/filter/md/wrtmd.cxx    |    2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 0ccbc44b7ca41d5080576c0c496aa7cfcdf58fc6
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sun Jul 13 16:21:15 2025 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Mon Jul 14 09:47:41 2025 +0200

    cid#1659052 COPY_INSTEAD_OF_MOVE
    
    Change-Id: I4529bc615f3c1d3fc2b0617969d606fd4dedd852
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187810
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/sw/source/filter/md/wrtmd.cxx b/sw/source/filter/md/wrtmd.cxx
index 7d2a1cbfa85c..713ce380dbc5 100644
--- a/sw/source/filter/md/wrtmd.cxx
+++ b/sw/source/filter/md/wrtmd.cxx
@@ -177,7 +177,7 @@ void OutFormattingChange(SwMDWriter& rWrt, HintsAtPos& 
starts, HintsAtPos& ends,
         }
     }
 
-    current = result;
+    current = std::move(result);
 }
 
 void OutEscapedChars(SwMDWriter& rWrt, std::u16string_view chars)
commit 8212fc43839c0f1d7c5fa2c28efdfc0d01fabb42
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sun Jul 13 16:16:17 2025 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Mon Jul 14 09:47:34 2025 +0200

    cid#1659050 Uninitialized scalar field
    
    Change-Id: I71bccfe368dbc6c7dfae6e32fbac00aae2a82fbc
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187809
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/sw/source/core/fields/fldbas.cxx b/sw/source/core/fields/fldbas.cxx
index 0e5251732102..a24d9647e51b 100644
--- a/sw/source/core/fields/fldbas.cxx
+++ b/sw/source/core/fields/fldbas.cxx
@@ -857,6 +857,7 @@ SwValueField::SwValueField( SwValueFieldType* pFieldType, 
sal_uInt32 nFormat,
 SwValueField::SwValueField( const SwValueField& rField )
     : SwField(rField)
     , m_fValue(rField.GetValue())
+    , m_nFormat(rField.GetFormat())
 {
 }
 
commit 42a29a6b141bae05d3f00e4895db127adf19139b
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sun Jul 13 16:14:29 2025 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Mon Jul 14 09:47:27 2025 +0200

    cid#1659049 Resource leak
    
    Change-Id: I60637a01ff7cbe50e4df264d3c401799772743f0
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187807
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/sal/osl/unx/profile.cxx b/sal/osl/unx/profile.cxx
index b769b0ae90b3..05026da5e6fb 100644
--- a/sal/osl/unx/profile.cxx
+++ b/sal/osl/unx/profile.cxx
@@ -935,12 +935,13 @@ static bool OslProfile_lockFile(const osl_TFile* pFile, 
osl_TLockMode eMode)
 static osl_TFile* openFileImpl(const char* pszFilename, oslProfileOption 
ProfileFlags )
 {
     int        Flags;
-    osl_TFile* pFile = static_cast<osl_TFile*>(calloc(1, sizeof(osl_TFile)));
     bool       bWriteable = false;
 
     if ( isForbidden( pszFilename, osl_File_OpenFlag_Write ) )
         return nullptr;
 
+    osl_TFile* pFile = static_cast<osl_TFile*>(calloc(1, sizeof(osl_TFile)));
+
     if ( ProfileFlags & ( osl_Profile_WRITELOCK | osl_Profile_FLUSHWRITE ) )
     {
         bWriteable = true;